Draft: Added extra regions to index.html#3975
Draft: Added extra regions to index.html#3975jkriegshauser wants to merge 3 commits intoMagicMirrorOrg:developfrom
Conversation
|
Where is the css for those? |
84ff0f6 to
9d20fd8
Compare
Oops, left that out. I just pushed what I used. Though I'm also open to any other suggestions about adding regions that don't require modifying the index.html |
|
The detection code reads index.html to get the names |
|
The css could be in custom.css |
That's unfortunate. Where is the detection code?
Yeah that's where I had it prior to creating the PR. |
|
js/utils.js getModulePositions we validate all the positions used against the discovered list, cause before we might fail, or silently not show the module. we need the html to connect the styles to for proper positioning others want left/right in middle_center but you can also move a module right w css without a position |
This is a good point that i hadn't really considered. Let me see if there are any regions that I'm not using that i could just move into place rather than adding new ones |
|
you could easily have applied your right1 css to the module in bottom_left you don't need to move a position.. the whole page is open to css.. so you can put your module anywhere you like. |
|
Thanks, that actually did the trick. Closing this PR |
I added these regions a while ago locally so that my config could make use of them. And I'm tired of merging them in with each update, so I figured I'd try a pull request 😄